Skip to content

BLD: strict alias warning in float hashtable #18025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

BLD: strict alias warning in float hashtable #18025

merged 1 commit into from
Oct 31, 2017

Conversation

chris-b1
Copy link
Contributor

xref #17936

@chris-b1
Copy link
Contributor Author

Just as a sanity check, the new does optimize out identically
https://godbolt.org/g/qAtgXS

@jreback
Copy link
Contributor

jreback commented Oct 30, 2017

cool. i would run some asv just to check (should be the same)

@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #18025 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18025      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...61f2944. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #18025 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18025      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...61f2944. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 30, 2017 •
edited
Loading

Codecov Report

Merging #18025 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18025      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...61f2944. Read the comment docs.

@gfyoung gfyoung added Build Library building on various platforms Clean labels Oct 30, 2017
@jreback jreback added this to the 0.22.0 milestone Oct 31, 2017
@jreback jreback merged commit 6e11c10 into pandas-dev:master Oct 31, 2017
@jreback
Copy link
Contributor

jreback commented Oct 31, 2017

thanks @chris-b1 !

peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017
@chris-b1 @peterpanmj
BLD: alias warning in float hashtabl (pandas-dev#18025)
c4cc981
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@chris-b1 @No-Stream
BLD: alias warning in float hashtabl (pandas-dev#18025)
dcacd69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms Clean
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-b1 @jreback @gfyoung